Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add details to error message in Parse.Query.aggregate #9689

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 1, 2025

Pull Request

Issue

Returns Internal Server Error

Approach

Returns Invalid Query error with message

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

parse-github-assistant bot commented Apr 1, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.16%. Comparing base (9d8d494) to head (5ee3f11).
Report is 2 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9689      +/-   ##
==========================================
- Coverage   93.17%   93.16%   -0.01%     
==========================================
  Files         187      187              
  Lines       15066    15068       +2     
==========================================
+ Hits        14037    14038       +1     
- Misses       1029     1030       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dplewis added 2 commits April 1, 2025 09:48
@dplewis dplewis requested a review from a team April 1, 2025 15:28
mtrezza added 2 commits April 7, 2025 09:40
@mtrezza mtrezza changed the title feat: Improve handling aggregate query errors feat: Improve error handling in Parse.Query.aggregate Apr 7, 2025
@mtrezza mtrezza changed the title feat: Improve error handling in Parse.Query.aggregate perf: Improve error handling in Parse.Query.aggregate Apr 7, 2025
@mtrezza mtrezza changed the title perf: Improve error handling in Parse.Query.aggregate perf: Improve error handling in Parse.Query.aggregate with more meaningful error message Apr 7, 2025
@mtrezza mtrezza changed the title perf: Improve error handling in Parse.Query.aggregate with more meaningful error message perf: Add details to error message in Parse.Query.aggregate Apr 7, 2025
@mtrezza mtrezza merged commit 9de6999 into parse-community:alpha Apr 7, 2025
24 checks passed
parseplatformorg pushed a commit that referenced this pull request Apr 7, 2025
## [8.1.1-alpha.1](8.1.0...8.1.1-alpha.1) (2025-04-07)

### Performance Improvements

* Add details to error message in `Parse.Query.aggregate` ([#9689](#9689)) ([9de6999](9de6999))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.1.1-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants