Fix sign up user in cloud function#7351
Fix sign up user in cloud function#7351Yurgal wants to merge 4 commits intoparse-community:alphafrom
Conversation
|
@Yurgal You can click on "Details" to open the test log and see why it failed:
|
spec/ParseUser.spec.js
Outdated
| expect(user.get('authData')).toEqual({ custom: { id: 'linkedID' } }); | ||
| }); | ||
|
|
||
| describe('issue #6641', () => { |
There was a problem hiding this comment.
Can you either move the test into an existing describe group where this fest fits thematically, or if there is no such group, rename this describe group with a short description as you see in the other groups?
If I understand correctly, since the focus here is on auth via cloud code, I would see this test rather in an auth or cloud code spec file. Can you take a look whether there are any tests in auth files that are similar to what you are testing? That would be an indication that your test belongs there.
spec/ParseUser.spec.js
Outdated
| }) | ||
| .then(() => done()) | ||
| .catch(() => { | ||
| fail(); |
There was a problem hiding this comment.
I think we don't need any fail(), done(), these should be avoided when possible.
There was a problem hiding this comment.
I don't know how to properly handle the catch issue without fail()
There was a problem hiding this comment.
- for exceptions use expect().toThrow()
- for promise rejections use expect().toBeRejected()
|
hi @mtrezza I added a new test. As explain in the java documentation, |
|
@Yurgal You have to signUp with the installationId otherwise how will login find the user? See tests cases https://github.com/parse-community/Parse-SDK-JS/pull/1031/files |
|
New Pull Request Checklist
Issue Description
Trying to logIn a user using the
masterKeyand theinstallationIdwithout using thepasswordRelated issue: #6641
Approach
TODOs before merging