Skip to content

refactor: Upgrade expo-server-sdk from 3.15.0 to 4.0.0 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Upgrade expo-server-sdk from 3.15.0 to 4.0.0 #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@parse/node-apn": "6.5.0",
"@parse/node-gcm": "1.0.2",
"expo-server-sdk": "3.15.0",
"expo-server-sdk": "4.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Breaking: expo-server-sdk v4 drops Node 18; engines still allow 18 — align or postpone upgrade.

Upgrading to expo-server-sdk 4.0.0 drops support for Node v18.x. Your package.json still advertises Node "18 || 20 || 22", which can yield CI/runtime failures for users on Node 18. Either:

  • Drop Node 18 in engines and CI (preferred if you’re ready to deprecate 18), or
  • Postpone to the latest 3.x and keep Node 18 support.

Release note: “4.0.0 (2025-08-18) — Drop support for Node v18.x.” (newreleases.io)

Proposed diff (Option A: drop Node 18 to match dependency):

   "dependencies": {
     "@parse/node-apn": "6.5.0",
     "@parse/node-gcm": "1.0.2",
     "expo-server-sdk": "4.0.0",
     "firebase-admin": "13.5.0",
     "npmlog": "7.0.1",
     "parse": "6.1.1",
     "web-push": "3.6.7"
   },
   "devDependencies": {
@@
   },
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "20 || 22"
   }

Alternative (Option B: keep Node 18; defer upgrade):

-    "expo-server-sdk": "4.0.0",
+    "expo-server-sdk": "3.15.0",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"expo-server-sdk": "4.0.0",
"dependencies": {
"@parse/node-apn": "6.5.0",
"@parse/node-gcm": "1.0.2",
"expo-server-sdk": "4.0.0",
"firebase-admin": "13.5.0",
"npmlog": "7.0.1",
"parse": "6.1.1",
"web-push": "3.6.7"
},
"engines": {
"node": "20 || 22"
}
Suggested change
"expo-server-sdk": "4.0.0",
"dependencies": {
"@parse/node-apn": "6.5.0",
"@parse/node-gcm": "1.0.2",
"expo-server-sdk": "3.15.0",
"firebase-admin": "13.5.0",
"npmlog": "7.0.1",
"parse": "6.1.1",
"web-push": "3.6.7"
}
🤖 Prompt for AI Agents 
In package.json around line 29, the dependency bump to "expo-server-sdk":
"4.0.0" conflicts with your engines declaration allowing Node 18 (v4 drops Node
18 support); either align engines to remove Node 18 or revert the dependency to
a 3.x release. To fix: choose Option A — update the "engines" field and any CI
matrix to remove Node 18 (keep "20 || 22" or similar) and run CI locally to
confirm; or Option B — change the dependency back to the latest 3.x version in
package.json and update lockfile (npm/yarn install) so Node 18 remains
supported. Ensure the chosen option is applied consistently in package.json and
CI configs and commit the lockfile update.

"firebase-admin": "13.5.0",
"npmlog": "7.0.1",
"parse": "6.1.1",
Expand Down
Loading