Repository navigation
ci: Docker release crashes or times out under arm64 emulation - #3516
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Build-stage architecture and dependencies Dockerfile |
The build stage uses the build machine’s platform. Production dependency installation selects an npm CPU value from the target architecture or machine architecture, and rejects unsupported values. The explicit prepare and build command is removed. |
CI and release platform configuration .github/workflows/ci.yml, .github/workflows/release-automated.yml, .github/workflows/release-manual-docker.yml |
CI builds linux/amd64 and linux/arm64/v8 on ubuntu-latest with separate cache scopes. The CI and release workflows remove QEMU setup while retaining both build platforms. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk: 
278ad
-
Cross-platform builds use the build machine’s architecture. No merge-blocking issue was identified.
Pre-merge checks: 
-
Check name Status Explanation Title check The title begins with the accepted prefix "ci:" but the first letter after the prefix is lowercase ("Docker" is capitalized, but the title's first word after the prefix is "Docker" which is capitalize… Description check The description follows the repository template. It includes the required Pull Request boilerplate, a detailed Issue section, and an Approach section that explains the cross-build change, the removal … Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Security Check No security vulnerability pattern is introduced by the reviewed diff. The Dockerfile validates and maps TARGETARCH before using it, quotes the derived npm CPU value, and adds no untrusted command exec… Engage In Review Feedback No review feedback required engagement. The supplied review context reports no returned CodeRabbit review threads and zero actionable findings in the current review. Full details: Title check
-
Explanation
The title begins with the accepted prefix "ci:" but the first letter after the prefix is lowercase ("Docker" is capitalized, but the title's first word after the prefix is "Docker" which is capitalized). The prefix and capitalization both match the requirement. The title refers to the Docker release and arm64 emulation problem, which is the main subject, though the change itself is a cross-build change that removes emulation rather than a fix to a crash, so the title is partially related to the main change.
Full details: Description check
-
Explanation
The description follows the repository template. It includes the required Pull Request boilerplate, a detailed Issue section, and an Approach section that explains the cross-build change, the removal of QEMU, the new CI arm64 build, and the local verification. The Tasks section has the "Add changes to documentation" item checked, and "Add tests" is left unchecked, which the author should justify or address.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: Security Check
-
Explanation
No security vulnerability pattern is introduced by the reviewed diff. The Dockerfile validates and maps TARGETARCH before using it, quotes the derived npm CPU value, and adds no untrusted command execution or secret handling. Workflow additions use fixed matrix values and separate cache scopes. The diff changes no dependencies and adds no new permissions, tokens, or external actions; it removes QEMU setup steps.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Pull Request
Issue
The Docker release job builds the
linux/arm64/v8image on an x64 runner, so Node.js runs under QEMU emulation for the whole build stage of the arm64 image, includingnpm ciand the webpack build. This fails in two ways:qemu: uncaught target signal 4 (Illegal instruction)on runners with an AVX-512 CPU, the same crash as inDocker Build: address QEMU arm64 SIGILL crashes parse-server#10705. Here the build step then hangs until the timeout.Since July 2026, 11 of 17 Docker release jobs timed out and 1 failed in
npm ci; none of them published an image. 35 releases since September 2025 have no image on Docker Hub, among them8.5.0and 10 of the 149.3.0-alphareleases.Approach
This ports parse-community/parse-server#10706. The image is cross-built, so that no code runs under emulation and QEMU is not needed anymore.
FROM --platform=$BUILDPLATFORM). It installs the production dependencies for the architecture of the image withnpm ci --os=linux --cpu=<arch> --libc=musl. No production dependency is platform-specific yet, so this guards against future native dependencies. The webpack output does not depend on the platform.npm run prepare && npm run buildanymore.npm cialready runs thepreparescript, which builds the bundles inParse-Dashboard/public/bundles, the only bundles copied to the image;npm run buildwrites toproduction/andPIG/, which are not copied. This saves 3 of 4 webpack builds per platform, which matters more now that both platforms build at the same time.RUNinstruction; a comment now says it must not have one.BUILDPLATFORMandTARGETARCH, like the legacy Docker builder, run the build stage on their own platform and install the dependencies for it, as before.release-manual-docker.ymlbuilds a ref with a previous Dockerfile, BuildKit falls back to its own bundled QEMU, so that build is as slow and crash-prone as before.linux/arm64/v8image, which no longer needs emulation, so that the arm64 build is checked before a release. Each platform has its own build cache scope. The checkDocker linux/amd64keeps its name, so the required checks need no change.Raising the timeout was considered, but the arm64 build already takes most of the 60 minutes, and after a crash the step hangs until any timeout. Native arm64 runners were not chosen for the same reasons as in Parse Server: one job per platform and a job that merges the images in each release workflow.
Verified locally on an arm64 host with Docker 29.9.1, comparing images built with the previous and the new Dockerfile:
linux/amd64andlinux/arm64, the/srcfolder of both images is identical in content, file mode and owner, and so is the image configuration.nodewith the architecture of the image.DOCKER_BUILDKIT=0) and kaniko 1.23.2 build an image with the same/srcfolder as BuildKit. Alinux/arm/v7image builds and runs.Tasks
Summary by CodeRabbit