Conversation
Resolves the AccountAlias review-fixture conflict in favor of main's shape (shared PROOF_CONTEXT/RING_LOCATION constants plus the CreateProof case), which supersedes the branch-side repair of the same fixture. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ERussel
reviewed
Jul 20, 2026
pgherveou
reviewed
Jul 21, 2026
Comment on lines
+10
to
+13
| /// Derivation suffix selecting an account within the product subtree. | ||
| /// Interpreted as a standard substrate derivation-path segment when valid | ||
| /// UTF-8, and as a raw-bytes junction otherwise. | ||
| pub derivation_suffix: Vec<u8>, |
Collaborator
There was a problem hiding this comment.
We will need a v02 here and update the versioned enums with the new variant
Contributor
Author
There was a problem hiding this comment.
Iirc the direction is that we are ok to break things now, to iterate faster
Resolves the SsoAllocatedResource conflict by keeping main's variant doc comments while retaining this branch's AutoSigning payload shape (single product_root_private_key, no product_derivation_secret). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Changes 23.07
u32-LE ++ INDEX_MAGIC(blake2b256("product-account-index")[..28]); raw 32-byte values as escape hatchProductAccountId.derivation_index: Either<u32, [u8; 32]>at the host API; only the 32-byte form past itProductProofContext.suffix: arbitrary bytes → sameEither<u32, [u8; 32]>selector, with its own amendment sectionpeopl.dotbuilt-in product://peopl.dot//0full personhood key,//peopl.dot//1light personhood key;lite-people/peopledomains removedhash(root_entropy, "ecdh"); schnorrkel derivation dropped