fix decode compact prefix db #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
commented
Oct 2, 2025
turuslan
commented
- partial prefix for attached value was not appended
- add support for child trie root prefix
- also backported for State sync write db polkadot-sdk#9247
- partial prefix for attached value was not appended - support for child trie root prefix
bkchr
reviewed
Oct 2, 2025
- decode compact proof to prefixed db, trie read failed
bkchr
reviewed
Oct 2, 2025
trie-db/test/src/trie_codec.rs
Outdated
| ) { | ||
| // Reconstruct the partial DB from the compact encoding. | ||
| let mut db = MemoryDB::<L>::default(); | ||
| let mut db = PrefixedMemoryDB::<L>::default(); |
There was a problem hiding this comment.
You can not just change an existing test if you introduce new code. We for sure want to ensure that both still work.
Also you don't use your newly introduced function.
There was a problem hiding this comment.
I made new function decode_compact_from_iter_with_prefix to avoid breaking interface (new root_prefix arg).
Old decode_compact_from_iter just calls decode_compact_from_iter_with_prefix with empty prefix.
This test with PrefixedMemoryDB panics on master, so this branch fixes existing functionality.
- test both MemoryDB and PrefixedMemoryDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.