solc-json-interface: do not unconditionally skip serialization of custom keys #337
+84
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om keys Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
xermicus
changed the title
smiasojed
reviewed
Jun 2, 2025
| @@ -11,16 +11,18 @@ pub mod memory; | |||
| #[derive(Clone, Copy, Default, Debug, Serialize, Deserialize)] | |||
| pub struct PolkaVM { | |||
| /// The PolkaVM target machine memory configuration settings. | |||
| pub memory_config: MemoryConfig, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
There was a problem hiding this comment.
Would it be possible to add #[serde(default, skip_serializing_if = "Option::is_none")] to each struct field? That way, I could use the struct directly in Foundry.
There was a problem hiding this comment.
Isn't that futile? Serde deserializes absent optional fields to None anyways.
smiasojed
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data structure can be used to build the JSON input for
resolctoo. In that case serializing of provided custom options should not be dismissed.Makes the memory settings struct more modular as a drive-by.