Skip to content

[stable2412] Backport #8630 #8712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

Conversation

paritytech-release-backport-bot[bot]

Backport #8630 into stable2412 from eskimor.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8630-to-stable2412
git worktree add --checkout .worktree/backport-8630-to-stable2412 backport-8630-to-stable2412
cd .worktree/backport-8630-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 1a8313fb2f88053e931370811973e8ce0394686a
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 30, 2025
@github-actions github-actions bot requested a review from eskimor May 30, 2025 16:57
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

eskimor and others added 2 commits May 30, 2025 20:14
This PR provides:

1. The means for the runtime to configure a minimum price for sales.
2. Prevents renewals to get detached too much from current market, by
bumping them at least to the `end_price` of the current sale.

TODO:

- [x] Implement
- [x] Add tests
- [x] Fix runtimes/Make Rococo + Westend use the new price controller.
- [x] prdoc
- [x] Leave configurability to the runtime

---------

Co-authored-by: Robert <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Maciej <[email protected]>
@eskimor eskimor marked this pull request as ready for review May 30, 2025 18:18
@eskimor eskimor requested a review from a team as a code owner May 30, 2025 18:18
@EgorPopelyaev EgorPopelyaev merged commit c853065 into stable2412 Jun 10, 2025
117 of 140 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-8630-to-stable2412 branch June 10, 2025 12:42
@eskimor eskimor restored the backport-8630-to-stable2412 branch July 7, 2025 09:58
@eskimor eskimor deleted the backport-8630-to-stable2412 branch July 7, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants