Fix origin check in EPMB's manage extrinsic #10248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A4-backport-unstable2507
Contributor
Author
|
/cmd prdoc --bump major |
Ank4n
reviewed
Nov 10, 2025
sigurpol
reviewed
Nov 10, 2025
sigurpol
reviewed
Nov 10, 2025
sigurpol
approved these changes
Nov 10, 2025
Ank4n
approved these changes
Nov 10, 2025
Contributor
Ank4n
left a comment
Ank4n
left a comment
There was a problem hiding this comment.
Some nits to keep you entertained
substrate/frame/election-provider-multi-block/src/benchmarking.rs
Outdated
Show resolved
Hide resolved
| Self::phase_transition(phase); | ||
| Ok(().into()) | ||
| Ok(PostDispatchInfo { | ||
| actual_weight: Some(T::DbWeight::get().reads_writes(1, 1)), |
Contributor
There was a problem hiding this comment.
Nit: It also emits an event so its 2 writes 😛
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
auto-merge was automatically disabled
November 11, 2025 15:04
Pull Request is not mergeable
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10248-to-unstable2507
git worktree add --checkout .worktree/backport-10248-to-unstable2507 backport-10248-to-unstable2507
cd .worktree/backport-10248-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x 0ae4eef5be75040edd2063d088a916ab78e0c928
git push --force-with-lease |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
.. And - [x] Break down `Admin` and `Manager` origins for easier configuration - [x] update the corresponding weights - [x] a few more tests - [x] complete the `manage` test cases. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankan <[email protected]> (cherry picked from commit 0ae4eef)
|
Successfully created backport PR for |
EgrPrty
pushed a commit
that referenced
this pull request
Nov 12, 2025
Backport #10248 into `stable2509` from kianenigma. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankan <[email protected]> Co-authored-by: EgorPopelyaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. And
AdminandManagerorigins for easier configurationmanagetest cases.