[http client]: support HTTPS #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Feb 11, 2021
| @@ -167,4 +156,17 @@ mod tests { | |||
| let response = client.send_request(request).await.unwrap_err(); | |||
| assert!(matches!(response, Error::RequestTooLarge)); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
maybe a little bit heavy for a test
There was a problem hiding this comment.
I can remove it but just to demonstrate that it works :)
There was a problem hiding this comment.
I'd move it to the separate tests, it's more of integration test than unit test.
maciejhirsz
approved these changes
Feb 12, 2021
|
Closing this as #204 is getting reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189,
HTTPSis supported by surf which makes this quite simple to implement. The bad thing is that users can't disable it.I found a faulty unwrap where we should return an error instead, which this PR fixes too but surf::Error doesn't implement
std::errror::Error.Thus, I decided to switch toanyhowinsteadBox<dyn std::error::Error + Send + Sync>