Open
Conversation
…d into package-lock.json Without a top-level `name` field, npm falls back to the containing directory name. Anyone whose clone isn't named `paranext-core` will produce a `package-lock.json` with a different name on `npm install`, creating spurious diffs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
merchako
requested review from
irahopkinson,
lyonsil and
tjcouch-sil
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
irahopkinson
requested changes
Apr 14, 2026
Contributor
irahopkinson
left a comment
irahopkinson
left a comment
There was a problem hiding this comment.
@irahopkinson reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on merchako).
package.json line 2 at r1 (raw file):
{ "name": "paranext-core",
I don't think you can do this because of the way ERB scripts work with this and the release/app/package.json (where the name is). If you want to pursue this you should talk to @tjcouch-sil about this change.
Also note this is based off of the ai/main branch so this isn't something we can merge into main anyway.
Contributor
Author
|
Oh, in that case I have some investigating to do. Claude got confused and tried to merge with ai/main, which already caused other problems for me. This might be a red herring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"name": "paranext-core"to the rootpackage.jsonpackage-lock.jsonwith the correct nameProblem
The root
package.jsonhad nonamefield. npm falls back to the containing directory name when this field is absent, so anyone whose clone isn't in a folder namedparanext-core"(e.g. a folder namedcore) will produce apackage-lock.jsonwith that directory name after runningnpm install. This creates spurious diffs that can accidentally get committed.Test plan
npm installin the repo —package-lock.jsonshould show"name": "paranext-core"regardless of directory name🤖 Generated with Claude Code
This change is