Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGSEGV upon pkcs11.open_session_no_callbac #73

Closed
wants to merge 1 commit into from

Conversation

hansonchar
Copy link

#72

Signed-off-by: Hanson Char [email protected]

@hug-dev
Copy link
Member

hug-dev commented Dec 8, 2021

Hey @hansonchar!!

Thanks for the detailed bug report and the PR. As this file is automatically generated from bindgen, I guess that a long term solution would be to fix the code-generation side directly, so that it's fixed for everyone? I am afraid that we will overwrite your fix if we re-generate the code.

Is there any issue about that on the bindgen repo? Might be worth to discuss with them too. Also @joechrisellis added the libloading feature in bindgen so he might be able to give pointers!

@hansonchar
Copy link
Author

Make sense. Thanks!

@hansonchar hansonchar closed this Dec 8, 2021
@hug-dev
Copy link
Member

hug-dev commented Dec 8, 2021

I'll let the others share their thoughts though! Maybe it does not hurt to include that temporary as long as the new bindings also contain it!

@ionut-arm
Copy link
Member

As per my message in the issue - an approach that could help in the future with other problems as well could be to place those libloading calls from this PR in a separate method implemented in lib.rs, but allowing the user to decide which flags they want to pass down. Thoughts?

@hansonchar
Copy link
Author

Great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants