Refactor the current codebase #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains the following changes: - clean the directory tree to regroup common features with more explicit names - regroup CI testing into one workflow and add the mock service smoke test - simplify the README.md file instruction with what is currently there - change the way new tests are added to make it easier Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
refactor
branch
6 times, most recently
from
4fdd9e0 to
1e7e68c
Compare
Also formats the code Signed-off-by: Hugues de Valon <[email protected]>
ionut-arm
approved these changes
Sep 30, 2021
Comment on lines
+14
to
+15
| # TODO: with some import syntax or clever moduling, it might be possible not | ||
| # to have to do anything here? |
There was a problem hiding this comment.
Yeah, that would be pretty cool! Did you raise an issue for this, btw, at least to investigate? I don't think it's very clear what you mean just from this TODO
There was a problem hiding this comment.
Yep, will raise an issue after this.
anta5010
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the following changes:
names
test