Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gh actions #119

Closed

Conversation

reubenmiller
Copy link

Update github actions and also use the same rust toolchain action across the workflows (preferring the maintained action actions-rust-lang/setup-rust-toolchain)

hug-dev
hug-dev previously approved these changes Feb 24, 2025
Signed-off-by: reubenmiller <[email protected]>
@reubenmiller
Copy link
Author

Pushed another commit to update the setup-python gh action as well (since the CI checks failed)

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ionut-arm
Copy link
Member

Hmmm, we might need something newer than 3.7 here...

@reubenmiller
Copy link
Author

Hmmm, we might need something newer than 3.7 here...

Yes, Python 3.7 has been EOL since 2023...Since python is only used by the tests I'll bump it to the latest supported version 3.11 (I believe).

@reubenmiller
Copy link
Author

reubenmiller commented Feb 28, 2025

Sorry closing this as I'm blocked by other Rust things before this change can even be done (as the pipeline will fail for other reason not related to this PR).

I was trying to support open source, however it seems that repo hasn't had any maintenance on it in a while which makes it harder for users to contribute when all of the PR checks fail with the current code base.

I would love to contribute in the future, but the changes go beyond my Rust knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants