feat: warn when payable fallback function found but no receive function #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Dec 15, 2024
DaniPopes
approved these changes
Dec 15, 2024
TilakMaddy
force-pushed
the
feat/payable-fallback-without-receive
branch
from
1ddded1 to
adc0aae
Compare
TilakMaddy
commented
Feb 5, 2025
DaniPopes
reviewed
Feb 5, 2025
| contract P3 { | ||
| fallback() external payable {} | ||
|
|
||
| receive() external payable {} |
There was a problem hiding this comment.
Please add annotations for the warnings //~
There was a problem hiding this comment.
It's a bit strange 🤔 .. I tried
- Same line variant (//~ WARN: ...)
- Next line variant(//~^ WARN: ...)
but they both fail on cargo uitest payable_fallback 😕
There was a problem hiding this comment.
pushed a fix 8433135
the diagnostic was missing the main span (.span()) but then it also required a workaround for a edge case in ui_test
DaniPopes
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethereum/solidity/blob/03e2739809769ae0c8d236a883aadc900da60536/libsolidity/analysis/ContractLevelChecker.cpp#L544C1-L554C2