Skip to content

fix(mev): correct refund calculation in sim_bundle #19991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
Merged

fix(mev): correct refund calculation in sim_bundle #19991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/rpc/rpc/src/eth/sim_bundle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ where
}

// After processing all transactions, process refunds
// Store the original refundable value to calculate all payouts correctly
let original_refundable_value = refundable_value;
for item in &flattened_bundle {
if let Some(refund_percent) = item.refund_percent {
// Get refund configurations
Expand All @@ -355,9 +357,11 @@ where
// Add gas used for payout transactions
total_gas_used += SBUNDLE_PAYOUT_MAX_COST * refund_configs.len() as u64;

// Calculate allocated refundable value (payout value)
let payout_value =
refundable_value * U256::from(refund_percent) / U256::from(100);
// Calculate allocated refundable value (payout value) based on ORIGINAL
// refundable value This ensures all refund_percent
// values are calculated from the same base
let payout_value = original_refundable_value * U256::from(refund_percent) /
U256::from(100);

if payout_tx_fee > payout_value {
return Err(EthApiError::InvalidParams(
Expand Down
Loading