feat(network): add support for bootnodes_v4(enode) and bootnodes_v5(enr) #19988
+310
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuiweixie
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
…node and enr) in config file similiar in geth
cuiweixie
force-pushed
the
config-v4-v5-bootnodes
branch
from
dd0eab0 to
efccea4
Compare
cuiweixie
changed the title
cuiweixie
force-pushed
the
config-v4-v5-bootnodes
branch
from
efccea4 to
cf6da46
Compare
cuiweixie
force-pushed
the
config-v4-v5-bootnodes
branch
from
cf6da46 to
1f2219d
Compare
mattsse
requested changes
Nov 28, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
not opposed to this setting but this needs to be easier to follow, I admit all these settings are a bit complex especially discv5
so if we can make this easier to parse than I'm okay with this
could you perhaps elaborate on the use case here?
cuiweixie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for bootnodes_v4(enode) and bootnodes_v5(enr) in config file similiar in geth