Drop status td field in eth69 rlp encoding #14292
Open
+183
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 8, 2025
| } | ||
| } | ||
|
|
||
| impl Encodable for Status { |
There was a problem hiding this comment.
I've thought about this a bit, and now that I'm looking at this,
trying to squeeze these into one type is not very ideal.
I'd like to approach this differently by rolling dedicated version types, that should be easier to manage then doing encoding like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(potentially) Closes #12194
Continued with the option approach, but implemented a custom
PartialEqin which:total_difficulty=Noneandtotal_difficulty=0as equal, avoiding this comparison issue: (Support upcoming Eth69 Status message #12194 (comment))