Skip to content

[logging] Migrate HLE diagnostics to SharpEmuLog#80

Merged
par274 merged 1 commit into
par274:mainfrom
Digote:logging/hle-diagnostics
Jul 13, 2026
Merged

[logging] Migrate HLE diagnostics to SharpEmuLog#80
par274 merged 1 commit into
par274:mainfrom
Digote:logging/hle-diagnostics

Conversation

@Digote

@Digote Digote commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Route ModuleManager dispatch diagnostics through the HLE logger.
  • Route Aerolib resource loading status and failures through the Aerolib logger.
  • Preserve appropriate warning, info, and error levels.
  • Include the original exception when Aerolib loading fails.
  • Update project references and lockfiles for the internal logging dependency.

Why

These diagnostics were written directly to stderr, bypassing the configured
SharpEmu log sinks and file logging. This migration makes HLE and Aerolib
messages consistent with the rest of the structured logging infrastructure.

Validation

  • dotnet restore SharpEmu.slnx --locked-mode
  • dotnet build SharpEmu.slnx -c Release --no-restore
    • 0 warnings
    • 0 errors
  • dotnet publish src/SharpEmu.CLI/SharpEmu.CLI.csproj -c Release -r win-x64 --self-contained true --no-restore
  • reuse lint

Signed-off-by: Digote <45742711+Digote@users.noreply.github.com>
@par274 par274 merged commit 4bd4279 into par274:main Jul 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants