Skip to content

Fixed bug when parent cache was not cleared correctly after child removal #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed bug when parent cache was not cleared correctly after child removal #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb02115
Fixed typos
popov654 Jul 20, 2024
2128980
Fixed bug when parent cache was not cleared correctly after child rem…
popov654 Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/PHPHtmlParser/Dom/Node/HtmlNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ protected function clear(): void
$this->innerHtml = null;
$this->outerHtml = null;
$this->text = null;
$this->innerText = null;
$this->textWithChildren = null;

if ($this->parent !== null) {
Expand Down
2 changes: 1 addition & 1 deletion src/PHPHtmlParser/Dom/Node/InnerNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function getChildren(): array
$childrenIds[] = $child->id;
$child = $this->nextChild($child->id());
if (\in_array($child->id, $childrenIds, true)) {
throw new CircularException('Circular sibling referance found. Child with id ' . $child->id() . ' found twice.');
throw new CircularException('Circular sibling reference found on child with id ' . $child->id() . ' found twice.');
}
} while (true);
} catch (ChildNotFoundException $e) {
Expand Down