Prevent fatal when not an object #257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This looks like a good fix to me. I also added it to PR #289, so you could close this if you wanted. |
|
@paquettg please merge this 🙏 |
|
This repo is no longer maintained. I suggest moving to another one. See the comments in #289 |
mr-chetan
added a commit
to devanoxltd/php-html-parser
that referenced
this pull request
Aug 24, 2025
Added an is_object check before accessing tag methods in the parser to prevent potential errors when tag is not an object. https: //github.com/paquettg/pull/257 Co-Authored-By: Mark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #256