Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGN round export #345

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

PGN round export #345

wants to merge 5 commits into from
+245 −84

Conversation

Molrn
Copy link
Collaborator

@Molrn Molrn commented Apr 5, 2025 •
edited
Loading

image

Export works with Tornelo (PGN import doc)

@Molrn Molrn added this to the 2.6 milestone Apr 5, 2025
pascalaubry
pascalaubry requested changes Apr 6, 2025
View reviewed changes
Copy link
Collaborator

@pascalaubry pascalaubry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, I must have a closer look (but not today, busy all day).

@Molrn Molrn changed the title PNG round export PGN round export Apr 6, 2025
@Molrn Molrn requested a review from pascalaubry April 9, 2025 03:36
timothyarmes
timothyarmes previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@timothyarmes timothyarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested.

timothyarmes
timothyarmes approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@timothyarmes timothyarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Molrn
Copy link
Collaborator Author

Molrn commented Apr 9, 2025

@pascalaubry merge blocked without your approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyarmes timothyarmes timothyarmes approved these changes

@pascalaubry pascalaubry Awaiting requested review from pascalaubry

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Molrn @timothyarmes @pascalaubry