Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: return single result instead of iterating #44

Closed
wants to merge 1 commit into from

Conversation

krushiraj
Copy link

This bug can be reproduced when we try to download records from ArXiv on 2021-10-09. This happened earlier for a couple of times.

Issue is that the response has only one record and instead of having a single object in array it return the single object itself.

@krushiraj
Copy link
Author

@andrenarchy please review the changes and let me know if this is good or post your thoughts on a fix for this issue.

@krushiraj
Copy link
Author

Gentle reminder to have a look at this PR. :)

@gleachkr
Copy link

Hi - I'm using this library and hitting the same bug. It'd be lovely to have this merged.

@krushiraj
Copy link
Author

I realised this is a duplicate of #30 and that is a better fix. So closing this in it's favour.

PS: For whoever needs a fix immediately fork this repo with the fix and use the repo under you account as dependency. You can get back to this if they merge in future

If you are not familiar on how to add a git repo as dependency - https://stackoverflow.com/questions/23210437/npm-install-private-github-repositories-by-dependency-in-package-json

@krushiraj krushiraj closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants