Feature/use custom svg creation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial way of creating the SVG file was using an external library in which it was not clear on how certain calculations were done and thus the resulting scales had some issues with the padding and sometimes with the cutting rectangle. This commit now switches the SVG generation to SkiaSharp for the font paths and custom XML handling to create the SVG file. All calculations can now be seen in code (except for creating paths from font files). Also some tests were added to avoid future regressions.
Turns out clones (using definitions and use in svg) does not work properly with the plotter software, so this commit uses <rect> directly instead of referencing a definition by <use>
Due to the changes in the svg generation small issues with offsets are fixed in the scales. To be able to reproduce creating scales they are migrated once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.