Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Scales and Units #13

Merged
merged 5 commits into from
Jan 5, 2025
Merged

Added Scales and Units #13

merged 5 commits into from
Jan 5, 2025

Conversation

papaseppo
Copy link
Contributor

Added scales for small vessels.
Activated smaller units like ml, cl and dl

by the hobbybrauer.de thread.
Found I'd have myself a nice scale on my stuff.
-steel cup
-milk pot (used for umschöpfing)
-big old pan
-sansone fermenting pot
needed to allow for "ml" as VolumeUnit in New-Scale-Request.yml
Copy link
Owner

@papauorg papauorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PullRequest. Looks very good overall. I just have a few comments so the new files are applying the same naming conventions and some small design improvements

existing ensamble, minor tweaking of scales,
adjusted template master to have 30 mm scale length
@papaseppo
Copy link
Contributor Author

applied as suggested

@papaseppo papaseppo requested a review from papauorg January 5, 2025 17:23
offset text -2 for steel mug d070mm
@papaseppo papaseppo requested a review from papauorg January 5, 2025 18:53
@papauorg papauorg merged commit ec8a342 into papauorg:main Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants