add workflow to test the index generator #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
commented
Dec 2, 2024
| python3.9 -m venv "${pants_venv_dir}" | ||
| "${pants_venv_dir}/bin/pip" install -vv \ | ||
| --extra-index-url=http://127.0.0.1:8080/simple/ \ | ||
| pantsbuild.pants==2.18.0a0 |
There was a problem hiding this comment.
This choice of version is necessary for the test to succeed. Pip apparently ignores the links for newer Pants versions as invalid given our current index format. This will be updated once #1 lands and the index format is updated to comply with PEP 503.
huonw
approved these changes
Dec 2, 2024
I agree in principle especially since this repository has no way to format and typecheck the code. That said, tonight's effort is to do the minimum necessary to get some test coverage here. Adding Pants support seems like a follow up to me before exploring some other improvements I would like to do here (after the multi-level index PR). |
|
Follow-up sounds fine to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub Actions workflow to test the index generator. The test generates an index and then tries to install Pants into a new virtual environment using that index.