Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Dockerfile #49

wants to merge 3 commits into from

Conversation

ndahlquist
Copy link

These are the code changes we needed to make in order to get the app to work correctly from the Dockerfile. Unfortunately I had to move the directory structure, so feel free to close this if you think it is not a good change

@mridulgain
Copy link

Instead of ubuntu why not use node as base image?

@ndahlquist
Copy link
Author

Not sure; we didn't spend too much time optimizing, just wanted to fix the functionality.

For what it's worth, the old Dockerfile also appears to use ubuntu as the base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants