Repository navigation
fix(ui): count and filter every kept form event in the Forms timeline - #290
Merged
Merged
Conversation
The panel cut the selected form's events to the newest 200 before the timeline filtered and counted them. The server already keeps events up to limits.formTimeline (up to 2000) and the timeline draws at most 100, so the extra cut only hid kept events: the count stopped at 200 and the path, type and origin filters could not find older events. The fixed slice is gone.
erkamyaman
added
the
no-docs
erkamyaman
added
the
no-docs
github-actions
Bot
added
area: panel
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to Retained form events beyond 200 can now appear in timeline counts and filters. No concrete issue remains that blocks merging. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: counting and filtering all retained form events in the Forms timeline. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
Full details: Docstring Coverage
-
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)
-
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
-
-
- Commit to this branch
- Create a new PR
-
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
# Conflicts: # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CQUbrXfP.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-CufAYnYw.js # extension/ui/assets/browser-agent-rpc-BXhoSh1z-Dsu8xe_M.js # extension/ui/assets/index-CgvJVwtz.js # extension/ui/assets/index-EXPZcZbM.js # extension/ui/assets/index-oV-AD6Da.js # extension/ui/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
selectedEventsinapp/src/pages/forms-inspector.tsfiltered events to the selected form and then cut them with a fixed.slice(-200). The server already caps events atlimits.formTimeline(default 200, up to 2000), and the timeline draws at most 100 matches. So the fixed slice added nothing; it only threw away kept events before filtering and counting.Anyone who raised
limits.formTimelinegot a wrong Timeline:The fixed slice is removed. The server's limit decides how many events are kept, and the timeline still draws at most 100.
How it was verified
New "FormsInspector timeline" test in
app/src/__tests__/forms-panels.test.tswith 300 kept events andformTimeline: 500. It checks the "of 300" count, and that a path filter finds 50 older events. Onmainit shows "of 200". With the fix it passes. All panel and package tests pass.pnpm commit:check(commit messages follow the guidelines)pnpm format:checkpnpm typecheck(includes thengctemplate checks)pnpm test:panelandpnpm test:devtools(all passing)pnpm skills:check(when.claude/changed): not changedno-docs)pnpm extension:buildandextension/uicommittedSummary by CodeRabbit