DOC: Set __module__ attributes and remove core from documentation
#62727
+230
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
|
|
||
| __module__ = "pandas" | ||
| __module__ = "pandas.api.typing" |
There was a problem hiding this comment.
I get wanting NatType in the api,typing namespace, but do t we want pd.NaT in the pandas namespace? Same for pd.NA above
There was a problem hiding this comment.
Ack, I didn't realize we'd also need to consider __module__ on class instances. Thanks.
rhshadrach
changed the title
core from documentation
rhshadrach
changed the title
core from documentationcore from documentation
rhshadrach
commented
Oct 18, 2025
| or ("Dtype" in name and obj.__module__ == "pandas") | ||
| or (name == "Categorical" and obj.__module__ == "pandas") | ||
| # TODO: Can't seem to change __module__ | ||
| or name == "Interval" |
There was a problem hiding this comment.
Modifying __module__ on Interval doesn't seem to have an impact; I'm guessing because this is a cdef class?
There was a problem hiding this comment.
@jbrockmendel - this is about ready, just this last todo I think. Was wondering if you could have a look here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__module__on top-level public objects #55178 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR addresses all
__module__attributes of public objects that I can find with the exception of functions. It's not clear to me if we want to also be modifying the__module__attribute of e.g.pandas.factorizeand even if we do, I'd like to keep that separate as this PR is already becoming sizable.Remaining documentation that contains
.core.:API docs
User Guide
Getting Started
no output.