BUG: fix SeriesGroupBy.plot does not respect cmap parameter #62671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuoyahuang
changed the title
rhshadrach
requested changes
Oct 19, 2025
Comment on lines
+450
to
+456
| def f(obj, color=None, label=None): | ||
| plot_kwargs = dict(kwargs) | ||
| if color is not None: | ||
| plot_kwargs["color"] = color | ||
| if label is not None: | ||
| plot_kwargs["label"] = label | ||
| return obj.plot(*args, **plot_kwargs) |
There was a problem hiding this comment.
I think this is the same as the function f below; can you move to the top and just define once.
There was a problem hiding this comment.
Also rename to something meaningful; perhaps plot_group?
Comment on lines
+438
to
+439
| if colormap is not None and color is None: | ||
| from pandas.plotting._matplotlib.style import get_standard_colors |
There was a problem hiding this comment.
I think we should only do this when get_option("plotting.backend") == "matplotlib". Can you use the previous logic for any other backend.
| colormap=colormap, | ||
| color_type="default", | ||
| ) | ||
| kwargs = dict(kwargs) |
Comment on lines
+459
to
+460
| for i, (name, group) in enumerate(self._groupby): | ||
| results.append(f(group, colors[i], name)) |
There was a problem hiding this comment.
Suggested change
| for i, (name, group) in enumerate(self._groupby): | |
| results.append(f(group, colors[i], name)) | |
| for name, group, color in zip(self._groupby, colors): | |
| results.append(f(group, color, name)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeriesGroupBy.plotdoes not respectcmapparameter #56697doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Following screenshot is from running