-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Implemented NumbaExecutionEngine #61487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arthurlw
wants to merge
10
commits into
pandas-dev:main
Choose a base branch
from
arthurlw:numba_execution_engine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−14
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
aa42037
Implemented NumbaExecutionEngine
arthurlw db9f3b0
whatsnew
arthurlw 4cb240d
precommit
arthurlw 97d9063
Match function arguments
arthurlw 69e0e35
Fix CI
arthurlw 7365079
updated whatsnew
arthurlw c605857
Updated conditions and delegate method to numba.jit
arthurlw 24a0615
Added try and except to catch ImportError
arthurlw b7a2ecb
Use import_optional_dependency to load Numba
arthurlw 545db65
Merge branch 'main' into numba_execution_engine
arthurlw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I think it'd be a simpler approach is to implement this logic here:
https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L10563
There, now we are considering two cases:
__pandas_udf__
I would simplify that and just support engines with the engine interface
__pandas_udf__
:__pandas_udf__
Since we want to support
engine="numba"
for now, for compatibility reasons, what I would do is immediately afterDataFrame.apply
is called, convert the"numba"
string to a "fake" numba decorator with the__pandas_udf__
containing the theNumaExecutionEngine
class. Something like:From this point, all the code can pretend engine is going to be
None
for the default Python engine, or a__pandas_udf__
class, which should make things significantly.The challenge is that numba and the default engine share some code, and with this approach they'll be running independently. The default engine won't know anything about an
engine
parameter, and the numba engine will runNumbaExecutionEngine.apply
. If we don't want to repeat code, we'll probably have to restructure a bit the code, so some functions are generic and called by both engines.When we move the default engine to a
PythonExecutionEngine
class, maybe it's a good idea to have the base class with the code reused by different engines. But I think that change is to big to address in a single PR, so I'd see what can be done for now that it's not too big of a change.Does this approach makes sense to you?