Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST (string): from_dummies, dropna #60818

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Lines 3, 5, and 6 in the document Will shared last week. I think the line 5 one (dropna) would also be solved in a different way by #60797.

@mroeschke mroeschke added the Strings String extension data type and string data label Jan 30, 2025
@mroeschke mroeschke added this to the 2.3 milestone Jan 30, 2025
@mroeschke mroeschke merged commit ea7ff0e into pandas-dev:main Jan 30, 2025
46 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

Copy link

lumberbot-app bot commented Jan 30, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ea7ff0ea4606f47a672f75793f4ea2b3eb0b87f5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60818: BUG(string): from_dummies, dropna'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60818-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60818 on branch 2.3.x (BUG(string): from_dummies, dropna)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Feb 5, 2025
@jorisvandenbossche jorisvandenbossche changed the title BUG(string): from_dummies, dropna TST (string): from_dummies, dropna Feb 5, 2025
@jorisvandenbossche
Copy link
Member

Manual backport -> #60856

mroeschke pushed a commit that referenced this pull request Feb 5, 2025
BUG(string): from_dummies, dropna (#60818)

(cherry picked from commit ea7ff0e)

Co-authored-by: jbrockmendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants