Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arrow groupby na #60777

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix arrow groupby na #60777

wants to merge 4 commits into from
+19 −1

Conversation

asharmalik19
Copy link

@asharmalik19 asharmalik19 force-pushed the fix-arrow-groupby-na branch 4 times, most recently from 0e61611 to 66330ee Compare January 29, 2025 21:35
@rhshadrach rhshadrach self-requested a review January 30, 2025 21:41
rhshadrach
rhshadrach requested changes Jan 30, 2025
View reviewed changes
pandas/core/arrays/arrow/array.py Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
pandas/tests/extension/test_arrow.py Outdated Show resolved Hide resolved
@asharmalik19 asharmalik19 force-pushed the fix-arrow-groupby-na branch 2 times, most recently from 273d85f to 226ae6c Compare January 31, 2025 10:24
@asharmalik19 asharmalik19 force-pushed the fix-arrow-groupby-na branch 3 times, most recently from f973800 to 72beba9 Compare February 7, 2025 20:07
rhshadrach
rhshadrach approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, merging main should make the CI green.

@asharmalik19
Copy link
Author

The CI is now green. @rhshadrach can you please merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: groupby with dropna=False and pa.dictionary drops NA values
2 participants
@asharmalik19 @rhshadrach