Skip to content

BUG: Fix ValueError in DataFrame/Series regex replace for all-NA values #60691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
Original file line number Diff line number Diff line change
@@ -798,6 +798,7 @@ Other
- Bug in :meth:`Series.dt` methods in :class:`ArrowDtype` that were returning incorrect values. (:issue:`57355`)
- Bug in :meth:`Series.rank` that doesn't preserve missing values for nullable integers when ``na_option='keep'``. (:issue:`56976`)
- Bug in :meth:`Series.replace` and :meth:`DataFrame.replace` inconsistently replacing matching instances when ``regex=True`` and missing values are present. (:issue:`56599`)
- Bug in :meth:`Series.replace` and :meth:`DataFrame.replace` throwing ``ValueError`` when ``regex=True`` and all NA values. (:issue:`60688`)
- Bug in :meth:`Series.to_string` when series contains complex floats with exponents (:issue:`60405`)
- Bug in :meth:`read_csv` where chained fsspec TAR file and ``compression="infer"`` fails with ``tarfile.ReadError`` (:issue:`60028`)
- Bug in Dataframe Interchange Protocol implementation was returning incorrect results for data buffers' associated dtype, for string and datetime columns (:issue:`54781`)
3 changes: 2 additions & 1 deletion pandas/core/array_algos/replace.py
Original file line number Diff line number Diff line change
@@ -89,7 +89,8 @@ def _check_comparison_types(
op = np.vectorize(
lambda x: bool(re.search(b, x))
if isinstance(x, str) and isinstance(b, (str, Pattern))
else False
else False,
otypes=[bool],
)

# GH#32621 use mask to avoid comparing to NAs
7 changes: 7 additions & 0 deletions pandas/tests/frame/methods/test_replace.py
Original file line number Diff line number Diff line change
@@ -713,6 +713,13 @@ def test_replace_with_None_keeps_categorical(self):
)
tm.assert_frame_equal(result, expected)

def test_replace_all_NA(self):
# GH#60688
df = DataFrame({"ticker": ["#1234#"], "name": [None]})
result = df.replace({col: {r"^#": "$"} for col in df.columns}, regex=True)
expected = DataFrame({"ticker": ["$1234#"], "name": [None]})
tm.assert_frame_equal(result, expected)

def test_replace_value_is_none(self, datetime_frame):
orig_value = datetime_frame.iloc[0, 0]
orig2 = datetime_frame.iloc[1, 0]
7 changes: 7 additions & 0 deletions pandas/tests/series/methods/test_replace.py
Original file line number Diff line number Diff line change
@@ -708,3 +708,10 @@ def test_replace_ea_float_with_bool(self):
expected = ser.copy()
result = ser.replace(0.0, True)
tm.assert_series_equal(result, expected)

def test_replace_all_NA(self):
# GH#60688
df = pd.Series([pd.NA, pd.NA])
result = df.replace({r"^#": "$"}, regex=True)
expected = pd.Series([pd.NA, pd.NA])
tm.assert_series_equal(result, expected)