Type NAType
#1348
Open
Type NAType
#1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Aug 26, 2025
MarcoGorelli
commented
Aug 26, 2025
MarcoGorelli
commented
Aug 26, 2025
|
@MarcoGorelli pine me when I should review |
|
sure @Dr-Irv , happy for you to take a look, thanks! |
Dr-Irv
requested changes
Aug 26, 2025
…ndex` as they return `NotImplemented`
Dr-Irv
requested changes
Aug 27, 2025
tests/test_natype.py
Outdated
Comment on lines
90
to
104
| # bug upstream: https://github.com/pandas-dev/pandas/issues/62196 | ||
| # check( | ||
| # assert_type( | ||
| # divmod(na, s_int), | ||
| # tuple[pd.Series, pd.Series], | ||
| # ), | ||
| # tuple, | ||
| # ) | ||
| # check( | ||
| # assert_type( | ||
| # divmod(na, idx_int), | ||
| # tuple[pd.Index, pd.Index], | ||
| # ), | ||
| # tuple, | ||
| # ) |
There was a problem hiding this comment.
I'm OK to leave this in, with the #pyright: ignore, because it works with mypy. Then just make the comment about how pyright has the bug.
| # assert_type(divmod(s_int, na), tuple[pd.Series, pd.Series]), | ||
| # tuple, | ||
| # ) | ||
| # https://github.com/pandas-dev/pandas-stubs/issues/1347 |
There was a problem hiding this comment.
Isn't the bug upstream in pandas, not the orthogonal issue?
There was a problem hiding this comment.
I'd say this is both, here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has uncovered a couple of bugs:
so some tests have their assertions ignored for now, but i've linked to them in those places