Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks after RAG presentation #26

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Tweaks after RAG presentation #26

merged 1 commit into from
Mar 18, 2025

Conversation

pamelafox
Copy link
Owner

A couple tweaks made live:

  • Use an overlap of around 25% for splitting
  • Use a lower temp when query rewriting

Copy link

@tooshel tooshel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! still watching the video and you did make a few other changes but since I'm not done maybe you later undid it. Anyway, just wanted a funny way to say thanks!

@pamelafox
Copy link
Owner Author

@tooshel Lol thanks, the other change I made was adding to the system prompt a more explicit "If the answer isn't in the sources, say "I dont' know"".
It works without it though, I think that's fine to add live. 🤷🏼

@pamelafox pamelafox merged commit 0a4e74f into main Mar 18, 2025
1 check passed
@tooshel
Copy link

tooshel commented Mar 18, 2025

That's a good point . . . I didn't even consider that there was a bit of dramatization where you add stuff during the demo and it seems like you just thought of that but of course you practiced it that way. Which is why it was a such a compelling presentation! Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants