Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6093 where IPv6 addresses (e.g.
[::1]:8080orhttp://[::1]:8000/) were parsed incorrectly using.partition(":"), causing string splits on colons inside IPv6 host brackets.Root Cause
src/flask/app.py:server_name.partition(":")split"[::1]:8080"intosn_host = "[",sn_port = ":1]:8080".src/flask/testing.py:ctx.request.host.partition(":")[0]returned"["instead of normalized IPv6 host"::1".Solution
src/flask/app.pySERVER_NAMEparsing to check for"]:"orrpartition(":")to extract IPv6 host and port correctly.src/flask/testing.pysession_transactioncookie host parsing to handle IPv6 bracketed hosts.tests/test_basic.pytest_run_from_configfor[::1]:8080.test_session_transaction_ipv6intests/test_testing.py..partition(":")? #6093.