Remove collectionlog.net - Website shutdown #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your contribution. We'll be holding this change for a little bit to see how the situation folds out. If the website ends up being shut down with no replacement, we'd most likely want to either migrate users to a different provider, or disable the link & notify them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collectionlog.net has shut down as per the notice on their website.
This commit removes the related functionality in PlayerLookupService.java. I tested this change and the config item seems to fall back to 'None' automatically, however I'm not sure if a migration of the config item is preferred or if users should be notified of this removal with a chat message upon log in or something.