[IOPLT-605] Enforce config type

[kin0992]

Note

This is an alternative solution to fix a problem.
An issue has been opened to ask for help, but in the meantime we are reducing the human error enforcing the configuration type.

List of Changes

• Add the *__accountEndpoint variables to the config type
  • In this way we are enforcing the application to give an error if some configuration parameter is missing
• Improve type of OnOffCodec
• Add new environment variables to the api function

Important

On local development, it easier to use the connections string instead of the Azure Identity method to authenticate to the services.

It is recommended then to fill the *CosmosConnection parameter as well (the result is there is a *CosmosConnection and a *CosmosConnection__accountEndpoint variable populated).
Azure documentation says: "If the configured value is both an exact match for a single setting and a prefix match for other settings, the exact match is used.".

Motivation and Context

How Has This Been Tested?

Checklist before requesting a review

• I have performed a self-review of my code.
• I have committed only changes relevant to the task.
• I have minimized the number of changes.
• My changes are about only one task or issue.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2f5b22e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@infra/resources	Patch
functions-subscription	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPLT-605

[github-actions]

📖 Terraform Plan ('infra/resources/prod') - success

Terraform Plan

module.commons.module.function_consumptions_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]
module.commons.module.function_apis_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]
module.commons.module.function_consumptions_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [20s elapsed]
module.commons.module.function_apis_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [20s elapsed]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.commons.azurerm_dashboard.main will be updated in-place
  ~ resource "azurerm_dashboard" "main" {
      ~ dashboard_properties = jsonencode(
          ~ {
              + apiVersion = "2015-08-01-preview"
              + location   = "INSERT LOCATION"
              + name       = "Main"
              + tags       = {
                  + hidden-title = "Main"
                }
              + type       = "Microsoft.Portal/dashboards"
                # (2 unchanged attributes hidden)
            }
        )
        id                   = "/subscriptions/a2124115-ba74-462f-832a-9192cbd03649/resourceGroups/ts-p-itn-dashboards-rg-01/providers/Microsoft.Portal/dashboards/Main"
        name                 = "Main"
        tags                 = {}
        # (2 unchanged attributes hidden)
    }

  # module.commons.module.func_api.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
      ~ app_settings                                   = {
          + "ActivationConsumerCosmosDBConnection__accountEndpoint"          = "https://ts-p-itn-cosno-01.documents.azure.com:443/"
          + "SubscriptionHistoryCosmosConnection__accountEndpoint"           = "https://ts-p-itn-cosno-01.documents.azure.com:443/"
          + "SubscriptionRequestEventHubConnection__fullyQualifiedNamespace" = "ts-p-itn-main-evhns-01.servicebus.windows.net"
          + "TrialsCosmosConnection__accountEndpoint"                        = "https://ts-p-itn-cosno-01.documents.azure.com:443/"
            # (34 unchanged elements hidden)
        }
        id                                             = "/subscriptions/a2124115-ba74-462f-832a-9192cbd03649/resourceGroups/ts-p-itn-api-rg-01/providers/Microsoft.Web/sites/ts-p-itn-api-func-01"
        name                                           = "ts-p-itn-api-func-01"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Platform"
            "Owner"                                          = "TRIAL"
            "Source"                                         = "https://github.com/pagopa/trial-system"
        }
        # (26 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.commons.module.func_api.azurerm_linux_function_app_slot.this[0] will be updated in-place
  ~ resource "azurerm_linux_function_app_slot" "this" {
      ~ app_settings                                   = {
          + "ActivationConsumerCosmosDBConnection__accountEndpoint"          = "https://ts-p-itn-cosno-01.documents.azure.com:443/"
          + "SubscriptionHistoryCosmosConnection__accountEndpoint"           = "https://ts-p-itn-cosno-01.documents.azure.com:443/"
          + "SubscriptionRequestEventHubConnection__fullyQualifiedNamespace" = "ts-p-itn-main-evhns-01.servicebus.windows.net"
          + "TrialsCosmosConnection__accountEndpoint"                        = "https://ts-p-itn-cosno-01.documents.azure.com:443/"
            # (34 unchanged elements hidden)
        }
        id                                             = "/subscriptions/a2124115-ba74-462f-832a-9192cbd03649/resourceGroups/ts-p-itn-api-rg-01/providers/Microsoft.Web/sites/ts-p-itn-api-func-01/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Platform"
            "Owner"                                          = "TRIAL"
            "Source"                                         = "https://github.com/pagopa/trial-system"
        }
        # (22 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

Warning: Deprecated Resource

  with module.commons.azurerm_dashboard.main,
  on ../modules/commons/dashboard.tf line 7, in resource "azurerm_dashboard" "main":
   7: resource "azurerm_dashboard" "main" {

The `azurerm_dashboard` resource is deprecated and will be removed in v4.0 of
the AzureRM Provider - the replacement is available as
`azurerm_portal_dashboard`.

(and one more similar warning elsewhere)

Warning: Argument is deprecated

  with module.commons.module.apim.azurerm_monitor_diagnostic_setting.apim,
  on .terraform/modules/commons.apim/api_management/main.tf line 355, in resource "azurerm_monitor_diagnostic_setting" "apim":
 355: resource "azurerm_monitor_diagnostic_setting" "apim" {

`retention_policy` has been deprecated in favor of
`azurerm_storage_management_policy` resource - to learn more
https://aka.ms/diagnostic_settings_log_retention

(and 14 more similar warnings elsewhere)

Warning: Deprecated attribute

  on .terraform/modules/commons.cosmosdb_account/cosmosdb_account/output.tf line 54, in output "connection_strings":
  54:   value     = azurerm_cosmosdb_account.this.connection_strings

The attribute "connection_strings" is deprecated. Refer to the provider
documentation for details.

(and one more similar warning elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.