Skip to content

Conversation

@jgoussard
Copy link
Contributor

Issue

The response body comparator is using responses[status].content keys to find the content-type associated with responses. However, when the response is described via a $ref, it needs to be de-referenced before reading the content types keys.

Changes

  • De-reference the response schema earlier in the response body comparator
  • Added an operation & test case in oas-references fixtures

@vwong
Copy link
Collaborator

vwong commented Nov 28, 2025

Thanks for the fix. Can you add a changeset please? Just run npm run changeset:add. I feel this might be a "fix".

@jgoussard
Copy link
Contributor Author

Done @vwong, added the resulting .changeset to this PR - we need this fix to adopt the tool, do you have any approx ETA for release?

@vwong vwong merged commit d6e9e91 into pactflow:main Nov 30, 2025
2 checks passed
@YOU54F
Copy link
Member

YOU54F commented Dec 1, 2025

Thanks for the update @jgoussard - Are you using the using outside of, or as part of PactFlow? If PactFlow, SaaS or On-prem, so I can advise on when you will see this in product.

Alternatively if you are using the tool directly, it was released last night thanks to @vwong

https://github.com/pactflow/openapi-pact-comparator/releases/tag/v1.11.0

@jgoussard
Copy link
Contributor Author

We're using the tool directly @YOU54F - thanks a lot for the quick turnaround for the release - greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants