Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more customizable details for comment failures #769

Conversation

majamassarini
Copy link
Member

Copy link
Contributor

@majamassarini majamassarini force-pushed the fix/packit-service/2196 branch 2 times, most recently from ba93e15 to df17e44 Compare November 6, 2023 12:21
Copy link
Contributor

majamassarini added a commit to packit/packit-service that referenced this pull request Nov 6, 2023
Fixes #2196
Merge before packit/packit.dev#769

---

RELEASE NOTES BEGIN

User can now further customize comment messages (written by Packit as a
reaction of a failed job). The user can include in the customized
message the following new placeholders:
 - `logs_url`: service's logs url; Copr, Koji or Testing Farm service
depending on the Packit job
 - `packit_dashboard_url`: Packit dashboard url for the job
 - `external_dashboard_url`: service dashboard url; Copr, Koji or Testing
Farm service depending on the Packit job

RELEASE NOTES END
Comment on lines 417 to 419
- `{logs_url}`: replaced with the url to the service's logs, the service can be Copr, Koji or Testing Farm depending on the Packit job
- `{packit_dashboard_url}`: replaced with the Packit dashboard url for the job
- `{external_dashboard_url}`: url to the service dashboard, the service can be Copr, Koji or Testing Farm depending on the Packit job
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should provide some real example URLs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. If I point to the copr logs as an example I fear they will disappear after a while or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if the links become invalid in the future, I think it could at least give users the idea of what kind of URL we are talking about, so I would be still for adding some examples

@majamassarini majamassarini force-pushed the fix/packit-service/2196 branch from df17e44 to bd82041 Compare November 7, 2023 11:59
Copy link
Contributor

@majamassarini majamassarini force-pushed the fix/packit-service/2196 branch from bd82041 to cef7b40 Compare November 7, 2023 12:06
Copy link
Contributor

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Nov 10, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/7e3d537c7c924cb791db6534d59271fb

✔️ pre-commit SUCCESS in 1m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2bfe52e into packit:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants