-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more customizable details for comment failures #769
Add more customizable details for comment failures #769
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
ba93e15
to
df17e44
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 09s |
Fixes #2196 Merge before packit/packit.dev#769 --- RELEASE NOTES BEGIN User can now further customize comment messages (written by Packit as a reaction of a failed job). The user can include in the customized message the following new placeholders: - `logs_url`: service's logs url; Copr, Koji or Testing Farm service depending on the Packit job - `packit_dashboard_url`: Packit dashboard url for the job - `external_dashboard_url`: service dashboard url; Copr, Koji or Testing Farm service depending on the Packit job RELEASE NOTES END
docs/configuration/index.md
Outdated
- `{logs_url}`: replaced with the url to the service's logs, the service can be Copr, Koji or Testing Farm depending on the Packit job | ||
- `{packit_dashboard_url}`: replaced with the Packit dashboard url for the job | ||
- `{external_dashboard_url}`: url to the service dashboard, the service can be Copr, Koji or Testing Farm depending on the Packit job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should provide some real example URLs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. If I point to the copr logs as an example I fear they will disappear after a while or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if the links become invalid in the future, I think it could at least give users the idea of what kind of URL we are talking about, so I would be still for adding some examples
df17e44
to
bd82041
Compare
Build failed. ❌ pre-commit FAILURE in 1m 09s |
bd82041
to
cef7b40
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 24m 56s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 10s |
Merge after packit/packit-service#2245