log/logr/v2 with logr, zapr deps updated to v1.2.2

[joelrebel]

resolves #50

Note: This is a breaking change, hence versioned under /v2
to be imported as github.com/packethost/pkg/log/logr/v2

The current version of "github.com/packethost/pkg/log/logr" returns *PacketLogr as a logr.Logger,
which isn't possible anymore since in logr v1.2.2 logr.Logger is of type struct and it does not provide
the methods that old logr.Logger interface would declare.

https://github.com/go-logr/logr/blob/v1.2.2/logr.go#L230
https://github.com/go-logr/logr/blob/v0.4.0/logr.go#L148

With change, the NewPacketLogr() returns type *PacketLogr
which embeds the logr.Logger struct type, it inherits various methods
of the logr.Logger, although methods expecting a logr.Logger would need to
reference the *PacketLogr.Logger struct field.

The go-logr/logr v0.4.0 was an BETA API and is worth moving away from,
https://github.com/go-logr/logr/blob/v0.4.0/logr.go#L20

[codecov]

Codecov Report

Merging #51 (b6efe11) into master (3874146) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files           6        6           
  Lines         346      346           
=======================================
  Hits          258      258           
  Misses         70       70           
  Partials       18       18           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3874146...b6efe11. Read the comment docs.

[jacobweinstock]

Hey @joelrebel, we aren't really using semantic versioning in this module. we're still at v0.0.0. And with that being that case do we really need to move to v2? moving to v2 feels like we would be taking on the tradeoffs of backward compatibility, support, and maintainability of a stable version. Also, this logr package, in my opinion, should be deprecated. The only consumer I'm aware of is PBnJ. And PBnJ should just use go-logr directly.

[joelrebel]

@jacobweinstock, The reasoning for v2 is keep the current code around, while having the newer version with breaking changes available under /v2 - the version number picked was more of a Go practice than anything else.

Deprecating this package would be ideal for lesser indirections and since the multi module nature of this repository makes it harder to maintain. The main motivation for this is tinkerbell/pbnj#114