Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
NodeAccessorand related classes inpathable/accessors.pyto use the new__getitem__method for path traversal instead of directly calling_get_node. This change improves code readability and consistency by centralizing node access logic in a single method.Refactoring for centralized node access:
__getitem__method toNodeAccessorthat retrieves a node given a sequence of path parts, encapsulating path traversal logic._get_node(self.node, parts)withself[parts]throughout the file, ensuring all node lookups go through the new__getitem__method. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Documentation and comment updates:
get()orself[parts]) instead of the old_get_node()method, reflecting the refactor. [1] [2]This refactor makes the codebase easier to maintain and less error-prone by reducing duplication and clarifying the intended node access pattern.