Conversation
f4b0635 to
d2c7f53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major overhaul of the benchmarking tools for the
pathableproject. The benchmarks are now shipped as a public toolkit within the main package, providing a new CLI (pathable-bench) for running and comparing benchmarks. The old test-based benchmark scripts are deprecated but still available for compatibility. Documentation and CI workflows have been updated to reflect these changes.The most important changes are:
Benchmark Tooling and CLI:
Added a new public benchmark toolkit in the
pathable.benchmarkspackage, including a CLI entrypoint (pathable-bench) for running and comparing benchmarks. This CLI supports running parse and lookup scenarios, selecting implementations, and comparing results. [1] [2] [3] [4] [5] [6] [7] [8]Introduced implementation resolution logic to allow benchmarking arbitrary
BasePathsubclasses by dotted path or module:qualname syntax.Documentation Updates:
README.mdwith new instructions for installing and using the benchmark CLI, including optional extras for benchmark dependencies and highlighting the deprecation of the old test-based scripts.CI Workflow Updates: