Skip to content

add FuncPc for subtest#12

Merged
metafates merged 2 commits into
ozontech:mainfrom
Dinhar:funcpc-for-subtest
May 20, 2026
Merged

add FuncPc for subtest#12
metafates merged 2 commits into
ozontech:mainfrom
Dinhar:funcpc-for-subtest

Conversation

@Dinhar
Copy link
Copy Markdown
Contributor

@Dinhar Dinhar commented May 20, 2026

Added func pointer for subtests

Closes #4

@metafates metafates self-assigned this May 20, 2026
@metafates
Copy link
Copy Markdown
Member

metafates commented May 20, 2026

Thanks! Minor issue: we still have such comment on this field:

// FuncPC is the program counter (PC) of this test function.
//
// NOTE: it may be empty (zero) in some cases, e.g. hooks and sub-tests.
// Use with caution.
FuncPC uintptr

Let's change it to:

-// NOTE: it may be empty (zero) in some cases, e.g. hooks and sub-tests.
+// NOTE: it may be empty (zero) in some cases, e.g. hooks.

Also, let's update CHANGELOG.md with

## Unreleased

### Added

- Provide FuncPC for sub-tests.

@metafates metafates self-requested a review May 20, 2026 14:39
@metafates metafates merged commit 9de867d into ozontech:main May 20, 2026
5 checks passed
@metafates
Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide FuncPC for sub-tests

2 participants