Skip to content

NTSC phase detection (allows 3D decoder to be used)#278

Merged
harrypm merged 4 commits intooyvindln:vhs_decodefrom
eshaz:ntsc-phase-correct
Mar 5, 2026
Merged

NTSC phase detection (allows 3D decoder to be used)#278
harrypm merged 4 commits intooyvindln:vhs_decodefrom
eshaz:ntsc-phase-correct

Conversation

@eshaz
Copy link

@eshaz eshaz commented Mar 4, 2026

Fixes

  • Correctly detect NTSC chroma phase rotation sequence. This enables the use of the NTSC 3D chroma decoder for VHS and other color under sources.
    • The color burst phase is detected by converting each burst area into a complex signal (i.e. I/Q) and summing each burst's I/Q together for the entire field. The phase of the complex signal is measured and mapped to a quadrant which is used along with the isFirstField to select the correct NTSC phase rotation and field phase id.
  • Limit track phase switching to the last 16 lines of a field.
    • False positives were very infrequently appearing in the middle of the field for noisy EP VHS recordings.

@eshaz eshaz marked this pull request as ready for review March 4, 2026 04:07
@harrypm harrypm merged commit 3df5089 into oyvindln:vhs_decode Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants