Rigor pass - #10
Merged
Merged
Conversation
LICENSE, license fields, per-file headers. Remove Cargo.toml.bak and the unused Pipfiles; ignore instance state files written to the cwd.
puf: bound guest-written KEYSIZE. cpu: implement all SMLA variants, per-core VTOR fallback. rot_flash: unknown commands fail, persisted state read errors surface. gdb/soc: per-instance ports through one bounds-checked a4x2 helper. config: malformed --load-config is an error and unknown keys are named. main/rot-serve/analyze: errors, not panics, on user input.
Ignored socket, filesystem, and send errors now propagate or count. One-off debug dumps hardcoding image addresses are gone or gated. RoT traps log once per PC unconditionally. Spi2 BitSet/BitClear do read-modify-write. Crate-wide allow(dead_code) removed.
Fallout: gen is a keyword (renamed cs_gen); three if-let chains keep their idiomatic form over cargo fix's rescoping rewrite.
Mechanical: cargo fmt only.
Mostly collapsible_if let-chain rewrites; checked_div in UDIV, sort_unstable_by_key in the pc profiler, struct-update init in a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CI definition, running Oxide-approved clippy + rustfmt on 2024, and rewriting a number of comments and sprawling or inconsistent code areas.