Add mapping of cubby to sled ID to support bundles #9187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfchandler
force-pushed
the
wc/bundle-sled-to-cubby
branch
from
23c2038 to
1774fca
Compare
Currently support bundles contain the sled UUID in file paths, and serial number in `sled.txt`. However, when accessing the sled via the tech port we generally refer to a sled by its cubby. To make identification of sleds simpler, add a new `sled_info.json` file to the bundle with a JSON-encoded mapping of sled serial to cubby and UUID.
wfchandler
force-pushed
the
wc/bundle-sled-to-cubby
branch
from
1774fca to
21822fc
Compare
smklein
approved these changes
Oct 15, 2025
Comment on lines
+1497
to
+1512
| sled_info.insert( | ||
| sp_state.serial_number.to_string(), | ||
| SledInfo { cubby: Some(sp.slot), uuid: None }, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| // Sleds not returned by MGS. | ||
| for (serial, sled) in nexus_map { | ||
| sled_info.insert( | ||
| serial.to_string(), | ||
| SledInfo { | ||
| cubby: None, | ||
| uuid: Some(*sled.identity.id.as_untyped_uuid()), | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Smart to still include this info if a sled is present in one of "the nexus list" and "the MGS cubby list" but not the other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently support bundles contain the sled UUID in file paths, and serial number in
sled.txt. However, when accessing the sled via the tech port we generally refer to a sled by its cubby.To make identification of sleds simpler, add a new
sled_info.jsonfile to the bundle with a JSON-encoded mapping of sled serial to cubby and UUID.