Add cosmo support to reconfigurator #9134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karencfv
reviewed
Oct 8, 2025
| use typed_rng::TypedUuidRng; | ||
| let unique = unique.unwrap_or_else(|| hardware_slot.to_string()); | ||
| let model = format!("model{}", unique); | ||
| let model = "913-0000019".to_string(); |
There was a problem hiding this comment.
Is this a cosmo or gimlet model? I see it's used in several places. it would be really nice to have it as a constant so we know to use it where necessary
There was a problem hiding this comment.
Ah! I see it's for a gimlet. Can it be something like const DEFAULT_GIMLET_MODEL: &str = "913-0000019" ?
There was a problem hiding this comment.
This is the gimlet model. A constant is a good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.