-
Notifications
You must be signed in to change notification settings - Fork 50
set up API versioning machinery for most internal services #8789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect to see changes for three progenitor client packages that aren't here:
- ntp-admin
- sled-agent
- oximeter
SupportedVersion, SupportedVersions, api_versions, | ||
}; | ||
|
||
api_versions!([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had talked about versioning the three Clickhouse services separately in separate modules. Did you opt not to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I added a note in this block (just below here) suggesting that whoever finds a need to add a new version to these APIs should determine whether all the services should share the same versions, or whether to split them into modules. Although now a couple of days later I'm questioning my choices.
We also need to update the server implementations to actually process the Edit: to be clear, that's a change like this: Lines 98 to 105 in 811ee9a
If it's easy, that would be nice to do now because it'll be easy to forget later and that will break things. |
Part of #8727 (the easy ones)